Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split up e2e HMR test #3425

Merged
merged 1 commit into from
May 23, 2022
Merged

Split up e2e HMR test #3425

merged 1 commit into from
May 23, 2022

Conversation

matthewp
Copy link
Contributor

Changes

  • This is a test change, see below

Testing

  • Splits up the HMR test into pieces so the entire thing doesn't time out.

Docs

N/A, test refinement

@changeset-bot
Copy link

changeset-bot bot commented May 23, 2022

⚠️ No Changeset found

Latest commit: e63b494

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 23, 2022
natemoo-re
natemoo-re approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change! LGTM once things are passing.

@matthewp matthewp marked this pull request as ready for review May 23, 2022 19:52
@matthewp matthewp merged commit 28ede84 into main May 23, 2022
@matthewp matthewp deleted the e2e-win-fail branch May 23, 2022 19:56
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@matthewp
Split up e2e HMR test (withastro#3425)
b9fa094
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemoo-re natemoo-re natemoo-re approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewp @natemoo-re